-
Notifications
You must be signed in to change notification settings - Fork 616
Conversation
Wow, thanks @macie for the contribution. The end of sprint 30 is coming up on Wednesday, so I probably won't have time to fully review and test this pull request by then. I'll make sure this is on our list for sprint 31. |
Agree with Jason. OMG, that is a lot of help. |
Tagged Sprint 31. |
That is a great contribution. Thank you. BTW: did anybody try to install on a 32Bit System? |
depends=("brackets-lib" "gconf" "nodejs" "nspr" "systemd") | ||
makedepends=("prelink") | ||
optdepends=( | ||
"alsa-lib: <future use>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why asla-lib?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Namcap says that some library from brackets (libcef.so if I remember) needs (optional) alsa support. Look at current debian package dependencies (libasound2).
@macie I want to get a good grip on creating packages for arch linux. Is this https://wiki.archlinux.org/index.php/Creating_Packages a good resource or have you found others? |
awk '{printf "%.0f\n", $1 / 1000}'` | ||
# update control file | ||
cd "package-root/DEBIAN" | ||
awk -v arch=${ARCH} -v ver=${VERSION} -v size=${_SIZE} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of going back to awk
since we ported our older shell scripts to Grunt. However, I understand how you've streamlined the workflow here, so I'm willing to compromise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, interesting. When I wrote these scripts I think about future linux package makers, that they can create packages without knowledge of grunt. But is it right direction? Moving shell scripts to grunt seems to be much prettier. Bat files and mac shell scripts too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I don't think I care enough. 😄 This will be fine.
Can we rename |
@macie Initial review complete, but I haven't really reviewed the Arch packaging yet. I'm having some difficulties getting that setup. If you know someone else who is more familiar with Arch that can at least test your package and possibly review the PKGBUILD file, that would help. |
@jasonsanjose building packages for arch linux is quite simple. It use makepkg command on PKGBUILD file. Yes, PS. Apologize for my absence |
@macie thanks for the follow up. Please drop a comment for me here when you've pushed your changes. Please note that I'll be out on vacation starting the end of next week. If this pull request is still open @JeffryBooher will assist. Also note that our sprint ends next Wednesday, September 19. Ideally we would like to land these changes sooner to get more testing. |
@jasonsanjose Tomorrow I'll try to finish this pull request. |
Moved out of sprint 31 |
Linux universal installer
\ ..
| - / <– distro specified files, eg. PKGBUILD, control
| - /
| - linux/ <– common files, eg. brackets.desktop
| | - .INFO.template <– template (hidden) for INFO file
| \ - INFO
| - staging/ <– staging folder
| - build_installer.sh
| - _builder.sh
\ - _builder.sh
I check that 64-bit packages (for ubuntu and arch) builds without errors. I've successful instaled package for arch 64-bit and for ubuntu 64-bit (via https://aur.archlinux.org/packages/brackets/ script).
I use "sprint30" as version number, but perhaps better would be full version number – "0.30.0-0"?